[BuildRules] Added support to skip header consistency checks for selected files#8242
Merged
smuzaffar merged 1 commit intoIB/CMSSW_13_0_X/masterfrom Jan 11, 2023
Merged
Conversation
Contributor
Author
|
please test |
Contributor
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
Contributor
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-096360/29903/summary.html Comparison SummarySummary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See cms-sw/cmssw#39710
Some times we need to keep the headers in the release to properly print the error and suggest a proper solution to developers. With this new build rule now one should be able to add
<flags IGNORE_HEADER_CHECK="file1 file2"/>(wherefile1andfile2are relative file path inder package's interface directory) to instruct scram to not run header consistency checks for these files.